Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eliminate src directory in non-root example #1268

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Dec 28, 2024

Issue

Change

Move the contents of the src directory in examples/included-as-non-root up one level to the root of the project and then eliminate the src directory.

Verification

On Windows 11, using Docker Desktop for Windows, in a cmd terminal window:

git clone https://github.com/cypress-io/cypress-docker-images
cd cypress-docker-images
cd examples/included-as-non-root
docker run --rm -v .:/test -w /test -u node cypress/included

Repeat in a PowerShell terminal window.

Repeat on Windows 11, using Docker Desktop for Windows, in WSL2 running Ubuntu 24.04.1 LTS.

@MikeMcC399 MikeMcC399 self-assigned this Dec 28, 2024
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added type: enhancement example 💎 Need to create a good example labels Dec 28, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review December 28, 2024 18:06
@jennifer-shehane jennifer-shehane merged commit 21864f0 into cypress-io:master Dec 30, 2024
33 checks passed
@MikeMcC399 MikeMcC399 deleted the non-root-windows-compatible branch December 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example 💎 Need to create a good example type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants